On 3 April 2013 19:02, Richard Kuo <r...@codeaurora.org> wrote: > + /* check if we would overflow the alt stack */ > + if (on_sig_stack(sp) && !likely(on_sig_stack(sp - frame_size))) > + return (void __user __force *)-1UL;
I found the !likely construction confusing, as its doing both a 'unlikely' (right?) and inverting the argument. It seems clearer, to idiots like me, to write this as: if (on_sig_stack(sp) && unlikely(!on_sig_stack(sp - frame_size))) since where checking for overflow, and its unlikely that the overflow happened. -- Linas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
