Albert D. Cahalan writes:
> Richard Gooch writes:
>
> > We want to take out that union because it sucks for virtual
> > filesystems. Besides, it's ugly.
>
> I hope you won't mind if people trash this with benchmarks.
But they can't. At least, not for a well designed patch. If there is a
real issue of fragmentation, then there are ways to fix that without
using a bloated union structure. Don't punish some filesystems just
because others have a problem.
Solutions to avoid fragmentation:
- keep a separate VFSinode and FSinode slab cache
- allocate an enlarged VFSinode that contains the FSinode at the end,
with the generic pointer in the VFSinode part pointing to FSinode
part.
It's simply wrong to bloat everyone because some random FS found it
easier to thow in a union.
Besides, for every benchmark that shows how fragmentation hurts, I can
generate a benchmark showing how inode bloat hurts. Lies, damn lies
and benchmarks.
Regards,
Richard....
Permanent: [EMAIL PROTECTED]
Current: [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
