Oleg Nesterov <o...@redhat.com> wrote: > Looks correct, but can't we simpluify it a bit? > > info = call_usermodehelper_setup(session_keyring); > if (!info) > return ENOMEM;
-ENOMEM;-) > key_get(session_keyring)); > return call_usermodehelper_exec(info); Looks reasonable. I like it better this way as it makes working out how to deal with all the error cases so much simpler:-). Acked-by: David Howells <dhowe...@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/