On 02/07/2013 04:44 PM, Arnd Bergmann wrote: > On Thursday 07 February 2013, Rob Herring wrote: >> From: Rob Herring <rob.herr...@calxeda.com> >> >> In the recently added support for OF based clocksource init, a device node >> will be matched twice. We can fix this by passing the device node to the >> init functions and removing the match functions within the init functions. >> >> This is based on arm-soc for-next branch and commit "of: fix incorrect >> return value of of_find_matching_node_and_match()" in my DT for-next >> branch. >> > > Acked-by: Arnd Bergmann <a...@arndb.de> > > Conceptually this is definitely the way to go, but I noticed that > you create build warnings for the bisection points after the > first patch. I would suggest actually merging the first three > patches into one and also changing the prototype for the tegra > function in that patch to avoid this. >
How so? I don't see a warning as there is no type checking on the init function since of_device_id.data is just a void *. It would be good to have type checking here if you know a way, but I don't. I agree it is a bit abusive and can change it as you suggest. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
