On Tue, Jan 29, 2013 at 1:07 PM, Anatolij Gustschin <ag...@denx.de> wrote:
> Exporting gpios throws genirq error messages like > > genirq: Setting trigger mode 0 for irq 44 failed > (mpc512x_irq_set_type+0x0/0x18c) > > Do not set IRQ_TYPE_NONE in mapping function. Setting this type here > ends up in returning error code in driver's irq_set_type() function > and this triggers the genirq error message. > > Signed-off-by: Anatolij Gustschin <ag...@denx.de> > --- > drivers/gpio/gpio-mpc8xxx.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c > index 9ae29cc..a0b33a2 100644 > --- a/drivers/gpio/gpio-mpc8xxx.c > +++ b/drivers/gpio/gpio-mpc8xxx.c > @@ -292,7 +292,6 @@ static int mpc8xxx_gpio_irq_map(struct irq_domain *h, > unsigned int virq, > > irq_set_chip_data(virq, h->host_data); > irq_set_chip_and_handler(virq, &mpc8xxx_irq_chip, handle_level_irq); > - irq_set_irq_type(virq, IRQ_TYPE_NONE); git blame says this line was put there by the IRQ subsystem maintainer Thomas Gleixner. I feel very nervous about removing that, and you need a better explanation what is causing the problem and how in the commit. Like I want to know for sure that the problem is not triggered from somewhere else. Please write how and where you export this to trigger the error. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
