> On Thu, 24 Jan 2013, Simon Wood wrote: > >> From: simon <simon@simon-virtual-machine.(none)> >> >> Add support the SRW-S1 by patching HID descriptor to read axis >> as Generic Desktop X, Y and Z (rather than Usage page being >> 'Simulation'). >> >> Signed-off-by: Simon Wood <si...@mungewell.org> >> tested-by: John Murphy <rosegarde...@freeode.co.uk> > > Hi Simon, > > thanks for the patch. > >> >> --- >> drivers/hid/Kconfig | 6 +++++ >> drivers/hid/Makefile | 1 + >> drivers/hid/hid-core.c | 1 + >> drivers/hid/hid-ids.h | 3 +++ >> drivers/hid/hid-srws1.c | 58 >> +++++++++++++++++++++++++++++++++++++++++++++++ > > Is hid-srws1 really the best name? My understanding is that the vendor is > called Steelseries, and we mostly stick to calling the drivers according > to the device vendors (and grouping the quirks accordingly). > > So how about hid-steelseries?
I'm happy to change it; However Steelseries' other devices are all keyboards/mice intended for/marketed at gamers. Since other Steelseries devices are unlikely to have the same structure (OK I'm just guessing on that) is it better to keep this driver somewhat 'seperated'? I mean, not make life difficult trying to merge keyboard code in with this wheel's code.... if that is required in future. If you still would prefer a name change I can do that. In which case is the naming of the LED interfaces still OK? ie. -- echo 1 > /sys/class/leds/SRWS1\:\:69005002125011007452\:\:RPM3/brightness -- Thanks, Simon. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
