On 01/14/2013 10:14 AM, Cong Ding wrote:
the file should be closed if it goes to error.
What tool are you using to generate all these patches?
Signed-off-by: Cong Ding <ding...@gmail.com>
---
arch/x86/boot/compressed/mkpiggy.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/boot/compressed/mkpiggy.c
b/arch/x86/boot/compressed/mkpiggy.c
index 958a641..e29154f 100644
--- a/arch/x86/boot/compressed/mkpiggy.c
+++ b/arch/x86/boot/compressed/mkpiggy.c
@@ -58,6 +58,7 @@ int main(int argc, char *argv[])
if (fread(&olen, sizeof(olen), 1, f) != 1) {
perror(argv[1]);
+ fclose(f);
The next line is a return from main(). All FILEs will be automatically
closed by the C library, so your change is redundant.
The x86 maintainers can do what ever they want with it. But to me, it
seems like unnecessary code churn.
David Daney
return 1;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
