On Mon, Dec 24, 2012 at 11:14:06AM +0900, Akinobu Mita wrote: > batadv_iv_ogm_emit_send_time() attempts to calculates a random integer > in the range of 'orig_interval +- BATADV_JITTER' by the below lines. > > msecs = atomic_read(&bat_priv->orig_interval) - BATADV_JITTER; > msecs += (random32() % 2 * BATADV_JITTER); > > But it actually gets 'orig_interval' or 'orig_interval - BATADV_JITTER' > because '%' and '*' have same precedence and associativity is > left-to-right. > > This adds the parentheses at the appropriate position so that it matches > original intension. > > Signed-off-by: Akinobu Mita <akinobu.m...@gmail.com> > Cc: Marek Lindner <lindner_ma...@yahoo.de> > Cc: Simon Wunderlich <s...@hrz.tu-chemnitz.de> > Cc: Antonio Quartulli <or...@autistici.org> > Cc: b.a.t.m....@lists.open-mesh.org > Cc: "David S. Miller" <da...@davemloft.net> > Cc: net...@vger.kernel.org > ---
Acked-by: Antonio Quartulli <or...@autistici.org> But I would suggest to apply this change to net, since it is a fix. Cheers, -- Antonio Quartulli ..each of us alone is worth nothing.. Ernesto "Che" Guevara
pgpZ1jxN4TR8b.pgp
Description: PGP signature
