On Thu,  6 Dec 2012 21:03:44 -0500 Naoya Horiguchi <n-horigu...@ah.jp.nec.com> 
wrote:

> This patch fixes the warning from __list_del_entry() which is triggered
> when a process tries to do free_huge_page() for a hwpoisoned hugepage.
> 
> ChangeLog v2:
>  - simply use list_del_init instead of introducing new hugepage list
> 
> Signed-off-by: Naoya Horiguchi <n-horigu...@ah.jp.nec.com>
> ---
>  mm/hugetlb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 59a0059..9308752 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -3170,7 +3170,7 @@ int dequeue_hwpoisoned_huge_page(struct page *hpage)
>  
>       spin_lock(&hugetlb_lock);
>       if (is_hugepage_on_freelist(hpage)) {
> -             list_del(&hpage->lru);
> +             list_del_init(&hpage->lru);

Can we please have a code comment in here explaining why
list_del_init() is used?

>               set_page_refcounted(hpage);
>               h->free_huge_pages--;
>               h->free_huge_pages_node[nid]--;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to