Hi Tony,
On Wed, Dec 05, 2012 at 10:04:50PM +0000, Luck, Tony wrote:
> if (PageHWPoison(page) && !(flags & TTU_IGNORE_HWPOISON)) {
> - if (PageAnon(page))
> + if (PageHuge(page))
> + ;
> + else if (PageAnon(page))
> dec_mm_counter(mm, MM_ANONPAGES);
> else
> dec_mm_counter(mm, MM_FILEPAGES);
>
> This style minimizes the "diff" ... but wouldn't it be nicer to say:
>
> if (!PageHuge(page)) {
> old code in here
> }
>
I think this need more lines in diff because old code should be
indented without any logical change.
Thanks,
Naoya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
