On Wed, 2012-11-28 at 23:33 +0100, Krzysztof Mazur wrote: > > Many ATM drivers store vcc in ATM_SKB(skb)->vcc and use it for > freeing skbs. Now they can just use atm_pop_skb() to free such > buffers. > > Signed-off-by: Krzysztof Mazur <krzys...@podlesie.net>
Note that this one didn't make it into the tree that Dave just pulled. Not that I didn't think it was a good idea, but it was just separate from the other "real" fixes — and the tree had already grown into a big enough pile from your original single patch! In <20121006154606.ga25...@shrek.podlesie.net> you posted another patch: > I think there is another problem here. The pppoatm gets a reference > to atmvcc, but I don't see anything that protects against removal > of that vcc. > > The vcc uses vcc->sk socket for reference counting, so sock_hold() > and sock_put() should be used by pppoatm. That one I think *isn't* needed, because we have properly fixed the races with vcc_destroy_socket(). I just wanted to check you agree...? -- David Woodhouse Open Source Technology Centre david.woodho...@intel.com Intel Corporation
smime.p7s
Description: S/MIME cryptographic signature
