2012/11/28 viresh kumar <viresh.ku...@linaro.org>: > On Wed, Nov 28, 2012 at 9:31 PM, viresh kumar <viresh.ku...@linaro.org> wrote: >> On Wed, Nov 28, 2012 at 5:22 PM, Rabin Vincent >> Isn't something wrong here? For common clk case shouldn't >> this be: >> >>> +#define clk_to_clk_core(clk) (&clk->clk) >>> +#define clk_core_to_clk(core) (container_of(clk, ...)) //not getting into >>> the exact format here >> >> Sorry, if i am missing basics. > > Ok. I saw these getting updated in 2/2. But it means this individual patch > is broken and this is not allowed i believe.
It would be better to use container_of / &clk->clk, yes. I wouldn't really describe it as "broken" though since it works fine as it is, since it's the first and only element. I will change it anyway. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
