One minor comment:
On 26.11.12 16:48:30, Jacob Shin wrote:
> __init int amd_pmu_init(void)
> {
> /* Performance-monitoring supported from K7 and later: */
> @@ -666,6 +749,10 @@ __init int amd_pmu_init(void)
> setup_event_constraints();
> setup_perfctr_core();
>
> + num_core_counters = x86_pmu.num_counters;
I would better move this to setup_perfctr_nb().
> +
> + setup_perfctr_nb();
> +
> /* Events are common for all AMDs */
> memcpy(hw_cache_event_ids, amd_hw_cache_event_ids,
> sizeof(hw_cache_event_ids));
Otherwise the whole patch set looks good.
Acked-by: Robert Richter <r...@kernel.org>
Thanks Jacob.
-Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
