On Tue, Nov 20, 2012 at 09:34:45AM +0000, Russell King - ARM Linux wrote:
> On Tue, Nov 20, 2012 at 01:22:16AM -0800, Dmitry Torokhov wrote:
> > Hi,
> >
> > When looking at recent driver conversions to managed resources (devm_*)
> > there
> > is no devm_clk_prepare() and similar functions, which forces mixing of 2
> > resource management styles (managed/classic) in the same driver, which is
> > not
> > great.
> >
> > This patch series adds more devm_* managed APIs to the CLK subsystem so that
> > driver conversions can be "pure".
>
> So, how do you ensure the correct ordering between clk_unprepare() and
> clk_put(), or even clk_disable() and clk_unprepare() ? I see nothing
> here which makes any guarantees as to the ordering of those operations
> upon cleanup.
devm_* calls form a stack so if you have
static void xxx_probe()
{
input = devm_input_allocate_device();
devm_request_irq();
...
devm_clk_prepare()
...
devm_clk_enable()
...
input_register_device();
return 0;
}
and
static int xxx_remove()
{
return 0;
}
then upon remove we'll execute:
input_unregister_device();
devm_clk_disable();
devm_clk_unprepare();
devm_free_irq();
input_free_device();
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
