On Sun, Nov 11, 2012 at 05:03:21PM +0000, David Woodhouse wrote: > On Sun, 2012-11-11 at 17:12 +0100, Krzysztof Mazur wrote: > > It would require using atomic ops because also pppoatm_pop() can > > modify this word. I think it's better to add additional word instead > > of using atomic ops. > > Or use the existing flags word, perhaps. Only one bit of which is > actually used already. We'd have to filter the new bit out in > pppoatm_devppp_ioctl(). >
In pppoatm_devppp_ioctl() we also don't have sk->sk_lock.slock lock. In original patch synchronization was trivial because callback from socket lock is used. I also though about sharing word with encaps enum - encaps needs only 2 bits, but it's ugly. Krzysiek -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
