Re: [patch] serial console vs NMI watchdog

[Robert Read]

On Sat, Mar 10, 2001 at 01:21:25AM +1100, Andrew Morton wrote:
> +static atomic_t nmi_watchdog_enabled = ATOMIC_INIT(0);       /* 0 == enabled */
> +
> +void enable_nmi_watchdog(int yes)
> +{
> +     if (yes)
> +             atomic_inc(&nmi_watchdog_enabled);
> +     else
> +             atomic_dec(&nmi_watchdog_enabled);
> +}
>  
>  void nmi_watchdog_tick (struct pt_regs * regs)
>  {
> @@ -255,7 +264,7 @@
>  
>       sum = apic_timer_irqs[cpu];
>  
> -     if (last_irq_sums[cpu] == sum) {
> +     if (last_irq_sums[cpu] == sum && atomic_read(&nmi_watchdog_enabled) == 0) {

Shouldn't that be atomic_read(&nmi_watchdog_enabled) != 0?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/