In current runtime PM implementation, the active child count of the
parent device may be decreased if the runtime PM of the child device
is disabled and forbidden. For example, to unbind a PCI driver with a
PCI device, the following code path is possible:
pci_device_remove
pm_runtime_set_suspended
__pm_runtime_set_status
atomic_add_unless(&parent->power.child_count, -1, 0)
That is, the parent device may be suspended, even if the runtime PM of
child device is forbidden to be suspended. This violate the rule that
parent is allowed to be suspended only after all its children are
suspended, and may cause issue.
This issue is fixed via checking the usage count of the child device
because if the runtime PM of the child device is forbidden, the
usage_count of the child device will be non-zero.
Signed-off-by: Huang Ying <ying.hu...@intel.com>
---
drivers/base/power/runtime.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/base/power/runtime.c
+++ b/drivers/base/power/runtime.c
@@ -916,7 +916,7 @@ int __pm_runtime_set_status(struct devic
if (status == RPM_SUSPENDED) {
/* It always is possible to set the status to 'suspended'. */
- if (parent) {
+ if (parent && atomic_read(&dev->power.usage_count) == 0) {
atomic_add_unless(&parent->power.child_count, -1, 0);
notify_parent = !parent->power.ignore_children;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
