Hello:
1) For Public Kernel:
A) in rt6_info_route function of net/ipv6/route.c
B) the length of rt->rt6i_dev->name is 16 (IFNAMSIZ)
C) using %16s is better than %8s (it will be more "beautiful")
(also suggest to delete RT6_INFO_LEN, it is useless for ever)
2) For Red Hat RHEL5:
A) in rt6_info_route function of net/ipv6/route.c
B) the length of rt->rt6i_dev->name is 16 (IFNAMSIZ)
C) for RT6_INFO_LEN is still useful, so it is an correctness issue.
the relative patch for RHEL5 is below:
-------------------------------------------------------------------------
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 08ab51f..3c90b4c 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -2285,7 +2285,7 @@ void inet6_rt_notify(int event, struct rt6_info
*rt, struct nlmsghdr *nlh,
#ifdef CONFIG_PROC_FS
-#define RT6_INFO_LEN (32 + 4 + 32 + 4 + 32 + 40 + 5 + 1)
+#define RT6_INFO_LEN (32 + 4 + 32 + 4 + 32 + 48 + 5 + 1)
struct rt6_proc_arg
{
@@ -2343,7 +2343,7 @@ static int rt6_info_route(struct rt6_info *rt,
void *p_arg)
arg->len += 32;
}
arg->len += sprintf(arg->buffer + arg->len,
- " %08x %08x %08x %08x %8s\n",
+ " %08x %08x %08x %08x %16s\n",
rt->rt6i_metric,
atomic_read(&rt->u.dst.__refcnt),
rt->u.dst.__use, rt->rt6i_flags,
rt->rt6i_dev ? rt->rt6i_dev->name : "");
----------------------------------------------------------------------------
--
Chen Gang
Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
