Hey, Michal. On Wed, Oct 31, 2012 at 10:23:59PM +0100, Michal Hocko wrote: > > + for_each_subsys(cgrp->root, ss) > > + if (ss->pre_destroy) > > + WARN_ON_ONCE(ss->pre_destroy(cgrp)); > > Do you think that BUG_ON would be too harsh?
Yeah, I do think so. In general, I think the consensus now is to prefer WARN_ON[_ONCE]() over BUG_ON() whenever possible. It's not like we can get more information from BUG_ON()s (more likely to get less reporting actually by taking down the machine). Limping machines are better than dead ones and there just isn't much to gain here by killing it. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
