On Tue, 16 Oct 2012 15:53:39 -0500
miny...@acm.org wrote:
> From: Corey Minyard <cminy...@mvista.com>
>
> There was a spot where the compiler couldn't tell some variables
> would be set. So initialize them to make the warning go away.
>
> Signed-off-by: Corey Minyard <cminy...@mvista.com>
> ---
> drivers/char/ipmi/ipmi_msghandler.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c
> b/drivers/char/ipmi/ipmi_msghandler.c
> index 2c29942..a0c84bb 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -1880,7 +1880,7 @@ int ipmi_request_supply_msgs(ipmi_user_t user,
> struct ipmi_recv_msg *supplied_recv,
> int priority)
> {
> - unsigned char saddr, lun;
> + unsigned char saddr = 0, lun = 0;
> int rv;
>
> if (!user)
The kernel build actually generates quite a lot of "bar uninitialised"
warnings for foo(&bar) expressions. I just ignore them, because later
versions of gcc stopped doing that.
The fix is OK, I suppose. But it will cause additional code to be
emitted. Using uninitialized_var() avoids that, and makes things
clearer to the reader.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
