On Mon 15-10-12 14:11:53, Viresh Kumar wrote: > On 15 October 2012 14:05, Michal Hocko <mho...@suse.cz> wrote: [...] > > I would suggest moving the common functionality into drivers/cpufreq/ > > (e.g. cpufreq_common.c). > > Initially i did that only, but then thought these routines must be present in > more generic files if possible, available across frameworks. > > Can we try renaming these to show there exact functionality and then put > them in generic files like, tick-sched.c?
But we already do have generic generic functionality for nohz case get_cpu_{idle,iowait}_time_us and kcpustat_cpu for !nohz. The only one that cares for both is /proc/stat code and it has its own helpers get_{idle,iowait}_time and as you can see it's demands are different from what governors want. -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/