On Sun, Feb 25 2001, Alexander Viro wrote:
> Erm... Jens, it really should be
>       if (atomic_dec_and_test(...))
>               up(...);
> not just
>       atomic_dec(...);
>       up(...);
> 
> Otherwise you can end up with too early exit of loop_thread. Normally
> it would not matter, but in pathological cases...

How so? We dec it and up the semaphore, loop_thread runs until it's
done and ups lo_sem.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to