On Tue, Sep 18, 2012 at 08:57:27PM -0700, Hugh Dickins wrote: > We should not be seeing non-0 unevictable_pgs_mlockfreed any longer. > So remove free_page_mlock() from the page freeing paths: __PG_MLOCKED > is already in PAGE_FLAGS_CHECK_AT_FREE, so free_pages_check() will now > be checking it, reporting "BUG: Bad page state" if it's ever found set. > Comment UNEVICTABLE_MLOCKFREED and unevictable_pgs_mlockfreed always 0. > > Signed-off-by: Hugh Dickins <hu...@google.com> > Cc: Mel Gorman <m...@csn.ul.ie> > Cc: Rik van Riel <r...@redhat.com> > Cc: Johannes Weiner <han...@cmpxchg.org> > Cc: Michel Lespinasse <wal...@google.com> > Cc: Ying Han <ying...@google.com>
Like Johannes I think you should just drop the counter. I find it very unlikely that there is a tool that depends on it existing because it's very hard to draw any useful conclusions from its value unlikes like say pgscan* or pgfault. Acked-by: Mel Gorman <m...@csn.ul.ie> Thanks Hugh. -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
