On Tue, 2012-09-11 at 09:27 +0800, Alex Shi wrote: > On 09/10/2012 11:26 PM, Peter Zijlstra wrote: > > > On Mon, 2012-09-10 at 15:10 +0800, Alex Shi wrote: > >> There is no load_balancer to be selected now. It just set state of > >> nohz tick stopping. > >> > >> So rename the function, pass the 'cpu' from parameter and then > >> remove the useless calling from tick_nohz_restart_sched_tick(). > > > > Please check who wrote the code you're patching and attempt to CC them > > as well, in this case Venki and Suresh. > > > Thanks! will care about this from now on. > > > > > I think the patch is fine, although I think we could have picked a > > better name, how about nohz_balance_enter_idle() ? > > > nohz_balance_enter_idle is good a name too. but I name it as > set_nohz_tick_stopped, since there is a clear_nohz_tick_stopped(), that > just do the opposed action of this function. According to this, is it > better to another function to nohz_balance_leave_idle()? > Or keep their current name? >
Yes that will be more appropriate name. Acked-by: Suresh Siddha <suresh.b.sid...@intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
