On Mon, Sep 10, 2012 at 1:55 PM, Mike Waychison <mi...@google.com> wrote: > Greg, > > Can you please pick this patch up in one of your trees?
Resend using a good email addy for gregkh :) > > Thanks! > > Mike Waychison > > On Fri, Jul 13, 2012 at 1:42 PM, Khalid Aziz <khalid.a...@hp.com> wrote: >> Some of the EFI variable attributes are missing from print out from >> /sys/firmware/efi/vars/*/attributes. This patch adds those in. It also >> updates code to use pre-defined constants for masking current value >> of attributes. >> >> Signed-off-by: Khalid Aziz <khalid.a...@hp.com> >> Cc: sta...@vger.kernel.org >> --- >> drivers/firmware/efivars.c | 17 ++++++++++++++--- >> 1 file changed, 14 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c >> index 47408e8..d10c987 100644 >> --- a/drivers/firmware/efivars.c >> +++ b/drivers/firmware/efivars.c >> @@ -435,12 +435,23 @@ efivar_attr_read(struct efivar_entry *entry, char *buf) >> if (status != EFI_SUCCESS) >> return -EIO; >> >> - if (var->Attributes & 0x1) >> + if (var->Attributes & EFI_VARIABLE_NON_VOLATILE) >> str += sprintf(str, "EFI_VARIABLE_NON_VOLATILE\n"); >> - if (var->Attributes & 0x2) >> + if (var->Attributes & EFI_VARIABLE_BOOTSERVICE_ACCESS) >> str += sprintf(str, "EFI_VARIABLE_BOOTSERVICE_ACCESS\n"); >> - if (var->Attributes & 0x4) >> + if (var->Attributes & EFI_VARIABLE_RUNTIME_ACCESS) >> str += sprintf(str, "EFI_VARIABLE_RUNTIME_ACCESS\n"); >> + if (var->Attributes & EFI_VARIABLE_HARDWARE_ERROR_RECORD) >> + str += sprintf(str, "EFI_VARIABLE_HARDWARE_ERROR_RECORD\n"); >> + if (var->Attributes & EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS) >> + str += sprintf(str, >> + "EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS\n"); >> + if (var->Attributes & >> + EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS) >> + str += sprintf(str, >> + >> "EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS\n"); >> + if (var->Attributes & EFI_VARIABLE_APPEND_WRITE) >> + str += sprintf(str, "EFI_VARIABLE_APPEND_WRITE\n"); >> return str - buf; >> } >> >> -- >> 1.7.9.5 >> >> -- >> Khalid Aziz >> khalid.a...@hp.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
