On Wed, 2012-09-05 at 17:09 +0200, Paolo Bonzini wrote: > Hi, > > this series fixes the bug I reported with wrong sense data. The > memory corruption is caused by using the sense data after freeing > it. The series corrects it by moving the copy of the sense data > earlier, to the transport_complete callback. > > Please review and be kind on my first lio patches! :) > > Paolo > > Paolo Bonzini (3): > target: move transport_get_sense_data > target: simplify code around transport_get_sense_data > target: fix use-after-free with PSCSI sense data > > drivers/target/target_core_pscsi.c | 21 ++---- > drivers/target/target_core_transport.c | 117 > ++++++++++++-------------------- > include/target/target_core_backend.h | 4 +- > 3 files changed, 53 insertions(+), 89 deletions(-) >
The approach to squash the bug looks easonable to me, and nice work on the extra cleanups for backend sense w/ TRANSPORT_PLUGIN_PHBA_PDEV ! I've applied this to target-pending/master w/ CC stable, and will plan to send out the PULL request for -rc5 over the next days. Nice work Paolo! --nab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
