On Fri, Aug 24, 2012 at 02:50:00PM +0100, Krystian Garbaciak wrote:
> This is MFD module providing access to registers and interrupts of DA906x
> series PMIC. It is used by other functional modules, registered as MFD cells.
> Driver uses regmap with paging to access extended register list. Register map
> is divided into two pages, where the second page is used during
> initialisation.
Your selection of people to CC here appears both large and random...
> +inline unsigned int da906x_to_range_reg(u16 reg)
> +{
> + return reg + DA906X_MAPPING_BASE;
> +}
I've no real idea what this stuff is all about, it at least needs some
comments somewhere. The fact that you're just adding a constant offset
to all registers is at best odd.
> + if (pdata->flags & DA906X_FLG_NO_CACHE)
> + config = &da906x_no_cache_regmap_config;
No, why would anyone ever want this and why would this not apply to all
other drivers?
> +static const struct i2c_device_id da906x_i2c_id[] = {
> + {"da906x", PMIC_DA9063},
> + {},
> +};
> +MODULE_DEVICE_TABLE(i2c, da906x_i2c_id);
List the actual devices here.
> +#define DA906X_IRQ_BASE_OFFSET 0
Hrm?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
