On Fri, Aug 24, 2012 at 01:28:16PM +0200, Marc Kleine-Budde wrote: > On 08/24/2012 07:10 AM, Kurt Van Dijck wrote: > > Hello, > > > > I find the CAN led triggers an interesting thing. > > > > And then, this scenario fell crossed my mind: > > Imagine I do: > > [insert CAN device: can0] > > $ ip link set can0 name helga > > [insert another CAN device: again 'can0'] > > > > Registering 'can0-tx' led trigger will fail for the second CAN device, > > since that led trigger name is already reserved for CAN device 'helga'. > > Good point. > > > I'm not sure how to fix such. > > If 'rx' & 'tx' may be combined, reusing the netdev name may be possible? > > Just wild thinking ... > > I think the device's name (not netdev) is unique in the system and > cannot be changed.
but may contain several netdev's ... > > On my device tree enabled mx28 I'm talking about the "80032000.can" in: You idea triggered another thougt: since control is put in device drivers, why putting the name in the generic can_dev struct? A more flexible approach to assign names is the key to success here. The correct 'works in all conditions' approach is not yet in my sight :-( Kurt > > regards, Marc > > -- > Pengutronix e.K. | Marc Kleine-Budde | > Industrial Linux Solutions | Phone: +49-231-2826-924 | > Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | > Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | > -- Kurt Van Dijck GRAMMER EiA ELECTRONICS http://www.eia.be kurt.van.di...@eia.be +32-38708534 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
