On 08/24/2012 07:10 AM, Kurt Van Dijck wrote: > Hello, > > I find the CAN led triggers an interesting thing. > > And then, this scenario fell crossed my mind: > Imagine I do: > [insert CAN device: can0] > $ ip link set can0 name helga > [insert another CAN device: again 'can0'] > > Registering 'can0-tx' led trigger will fail for the second CAN device, > since that led trigger name is already reserved for CAN device 'helga'.
Good point. > I'm not sure how to fix such. > If 'rx' & 'tx' may be combined, reusing the netdev name may be possible? > Just wild thinking ... I think the device's name (not netdev) is unique in the system and cannot be changed. On my device tree enabled mx28 I'm talking about the "80032000.can" in: > dmesg |grep flexcan > flexcan 80032000.can: device registered (reg_base=f5032000, irq=8) > flexcan 80034000.can: device registered (reg_base=f5034000, irq=9) > $ ls /sys/bus/platform/devices/*can* -d > /sys/bus/platform/devices/80032000.can > /sys/bus/platform/devices/80034000.can regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
