On Mon, 2012-08-20 at 16:59 +0200, Oleg Nesterov wrote:
> On 08/20, Peter Zijlstra wrote:
> >
> > task_work_cancel(struct task_struct *task, task_work_func_t func)
> > {
> > ...
> > +
> > +again:
> > + workp = &task->task_works;
> > + work = *workp;
> > + while (work) {
> > + if (work->func == func) {
>
> But this all can race with task_work_run() if task != current.
>
> This "work" can be freed/reused. And it should only return !NULL
> if twork->func() was not called.
Ah, because we could be iterating the list after the xchg done by run.
Hmm..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
