> -----Original Message----- > From: H. Peter Anvin [mailto:h...@zytor.com] > Sent: Saturday, August 18, 2012 10:25 PM > To: Yu, Fenghua > Cc: Henrique de Moraes Holschuh; Ingo Molnar; Thomas Gleixner; Mallick, > Asit K; Tigran Aivazian; Andreas Herrmann; Borislav Petkov; linux- > kernel; x86 > Subject: Re: [PATCH 04/11] x86/microcode_core_early.c: Define > interfaces for early load ucode > > On 08/18/2012 07:38 PM, Yu, Fenghua wrote: > > > > In this early phase, detecting vendor in initrd is much simpler code. > > Otherwise, detecting vendor by cpuid (and without cpuid) needs > > similar but different code as existing functions and coding would be > > awkward. > > > > I'm confused by this statement. Getting the vendor from CPUID is a few > lines of code, and non-CPUID processors don't support microcode loading. > Will checking vendor info from CPUID in next version.
> > Why name it ".hex" when you're loading binary data? I suggest ".bin". > It > > is confusing to have .hex there, since you're not dealing with the > Intel HEX > > format, nor anything text-like. > > Actually I think we can also skip one level of indirection here... no > need to mention "microcode" twice. > > kernel/x86/microcode/GenuineIntel or GenuineIntel.bin seems good > enough... the idea here of course is that the string can come from > CPUID. That's right. Will do this. Thanks. -Fenghua -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
