On Tue, Jul 31, 2012 at 08:49:21AM -0700, H. Peter Anvin wrote: > On 07/31/2012 03:42 AM, Konrad Rzeszutek Wilk wrote: > > > > [PATCH 3/3] x86: Let extend_brk return a NULL pointer instead of > > > >makes extend_brk not do BUG_ON and instead just return NULL. This allows > >us to handle the bootup issues more gracefully. > > > > NAK. The whole point of the brk allocator is that users specify the > upper limit on what they may need and stick to it. Hence it is a > fatal code bug if that is ever exceeded. We want to catch those > errors, not "handle" them.
OK, thanks for pointing that out. > > This means you're either abusing the brk allocator to do something > it is not meant to do... which may mean you can a failure in *other* > code, or you have a bug in your code that you haven't fixed. Its the latter - and of one of the patches in this patchset fixes that. Will drop the one that alter extend_brk. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
