(2012/07/21 11:19), Steven Rostedt wrote: > From: Uros Bizjak <ubiz...@gmail.com> > > The final position of the stack after saving regs and setting up > the parameters for ftrace_regs_call, is the position of the pt_regs > needed for the 4th parameter. Instead of saving it into a temporary > reg and pushing the reg, simply push the stack pointer. > > Link: http://lkml.kernel.org/r/1342702344.12353.16.ca...@gandalf.stny.rr.com >
Looks simple and readable :) Reviewed-by: Masami Hiramatsu <masami.hiramatsu...@hitachi.com> Thanks! > Signed-off-by: Uros Bizjak <ubiz...@gmail.com> > Signed-off-by: Steven Rostedt <rost...@goodmis.org> > --- > arch/x86/kernel/entry_32.S | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S > index 46caa56..4dc3017 100644 > --- a/arch/x86/kernel/entry_32.S > +++ b/arch/x86/kernel/entry_32.S > @@ -1169,10 +1169,9 @@ ENTRY(ftrace_regs_caller) > movl $__KERNEL_CS,13*4(%esp) > > movl 12*4(%esp), %eax /* Load ip (1st parameter) */ > - movl 0x4(%ebp), %edx /* Load parent ip (2cd parameter) */ > - lea (%esp), %ecx > - pushl %ecx /* Save pt_regs as 4th parameter */ > + movl 0x4(%ebp), %edx /* Load parent ip (2nd parameter) */ > leal function_trace_op, %ecx /* Save ftrace_pos in 3rd parameter */ > + pushl %esp /* Save pt_regs as 4th parameter */ > > GLOBAL(ftrace_regs_call) > call ftrace_stub > -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu...@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
