On Fri, Jul 20, 2012 at 04:38:58PM -0400, Jason Baron wrote: > On Thu, Jul 19, 2012 at 01:46:19PM -0600, Jim Cromie wrote: > > 3 patches here, 1st is bugfix, others are trivial. > > > > 1- fix __dev_printk, which broke dev_dbg() prefix under > > CONFIG_DYNAMIC_DEBUG. > > > > Patch looks good, and would be really nice to get into 3.5. Kay, are you > ok with this patch?
It's too late for 3.5, but I can take it for 3.6-rc1 and backport it to 3.5.1 if needed. I just need you ack :) > > 2- change dyndbg prefix interfield separator from ':' to '.' > > > > for example (output from test-code, not submitted): > > r8169 0000:02:00.0: r8169.rtl_init_one: set-drvdata pdev:ffff880223041000 > > dev:ffff880220d6a000 > > hwmon hwmon1: k10temp.k10temp_probe.180: set-drvdata pdev:ffff88022303d000 > > dev:ffff8801dfd2a000 > > > > This improves usability of cut -d: <logfile> for pr_debug() messages, > > as field position is less volatile with various uses of dyndbg flags. > > Its not perfect: > > - dev_dbg on net-devices adds several more colons, > > but this doesnt vary with dyndbg flags. > > - dyndbg=+pfmlt still adds a field vs dyndbg==p (ie no prefix) > > - pr_fmt() commonly adds another colon (unchanged with this patch) > > As you suggest in the patch, changing the delimiter to a non-colon > character such as ',' would resolve these cases? > > > > > 3- trivial var name change in lib/dynamic_debug.c > > > > > > Please drop or apply 2,3 as you prefer. > > 2,3 are nice, but as you suggest I think we want to separate them from > patch 1, which is a bugfix for 3.5. I agree. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
