On Mon, Jul 09, 2012 at 02:40:25PM +0200, Eric Dumazet wrote: > On Mon, 2012-07-09 at 08:13 -0400, Neil Horman wrote: > > On Mon, Jul 09, 2012 at 01:50:52PM +0200, Eric Dumazet wrote: > > > On Mon, 2012-07-09 at 07:01 -0400, Neil Horman wrote: > > > > > > > Thank you for doing this Eric, Gao. Just to be sure (I asked in the > > > > previous > > > > thread), would it be better to avoid the length check in > > > > skb_update_prio, and > > > > instead update the netdev tables to be long enough in cgrp_create and in > > > > netprio_device_event on device registration? > > > > > > Yes probably, and it is even needed because extend_netdev_table() can > > > acutally fail to expand the table if kzalloc() returned NULL. > > > > > > Current code just ignores this allocation failure so we also can crash > > > in write_priomap() > > > > > ACK, can you follow up with a patch please? > > Gao was working on this allocation problem (he privately sent me a v1 of > his patch), so I think we can wait Gao submit a v2 to combine all the > work/ideas in a single patch. > > (ie make sure we dont need additional bound checkings in fast path) > > Ok, I agree. thanks! Neil
> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
