On Thu Oct 8, 2026 at 4:02 PM CEST, Qiliang Yuan wrote:
> test_flow_dissector_skb_less_direct_attach() and
> test_flow_dissector_skb_less_indirect_attach() each create a netns to run
> in, and test_progs may run the two at the same time.
>
> Both name their netns flow_dissector_skb_less_indirect_attach_ns. When
> the two tests overlap, one of them fails to create or open the netns, or
> loses it to the cleanup of the other one.
>
> Name the netns of the direct attach test after that test.
>
> Fixes: 2b044dd186f0 ("selftests/bpf: re-split main function into dedicated
> tests")
> Signed-off-by: Qiliang Yuan <[email protected]>
Indeed, faulty copy-paste when the original test has been split, thanks
for the fix.
Reviewed-by: Alexis Lothoré (eBPF Foundation) <[email protected]>
> ---
> tools/testing/selftests/bpf/prog_tests/flow_dissector.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/flow_dissector.c
> b/tools/testing/selftests/bpf/prog_tests/flow_dissector.c
> index fb48926814647..f6fefb14cda3c 100644
> --- a/tools/testing/selftests/bpf/prog_tests/flow_dissector.c
> +++ b/tools/testing/selftests/bpf/prog_tests/flow_dissector.c
> @@ -706,7 +706,7 @@ void test_flow_dissector_skb_less_direct_attach(void)
> struct bpf_flow *skel;
> struct netns_obj *ns;
>
> - ns = netns_new("flow_dissector_skb_less_indirect_attach_ns", true);
> + ns = netns_new("flow_dissector_skb_less_direct_attach_ns", true);
> if (!ASSERT_OK_PTR(ns, "create and open netns"))
> return;
>
>
> ---
> base-commit: e1d84a37cba984388988d2f1ddc84561413f0db2
> change-id: 20261008-selftests-bpf-flow-dissector-netns-c347cf31e5f1
>
> Best regards,
--
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
