> In test_global_percpu_data.c, dump_percpu_data is defined after two
> non-autoload SEC("?kprobe") programs (verifier_strncmp and
> verifier_snprintf). Verify in test_global_percpu_data_lskel() that
> lskel->progs.dump_percpu_data.prog_fd is properly populated (> 0) when
> loaded via the light skeleton.
>
> Fixes: 4c9241bd731a ("selftests/bpf: Add tests to verify global percpu data")
> Fixes: 1ed2294b31fc ("selftests/bpf: Test verifier log for global percpu 
> data")

The existing Fixes tags point to commits 4c9241bd731a and 1ed2294b31fc,
but the specific test scenario being verified here (dump_percpu_data
program appearing after non-autoload programs) was only fully introduced
by commit 15945d02c6e1.

While the earlier commits laid groundwork (4c9241bd731a added
test_global_percpu_data_lskel(), 1ed2294b31fc added non-autoload
programs), the dump_percpu_data program itself was added in 15945d02c6e1.

Would it be more accurate to use:

  Fixes: 15945d02c6e1 ("selftests/bpf: Verify bpf_iter for global percpu data")


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/34245369055

Reply via email to