On Thu, Aug 06, 2026 at 11:08:50AM +0800, Hongfu Li wrote: > From: Hongfu Li <[email protected]> > > mseal_test main() invokes test_seal_mprotect_two_vma_with_gap() twice. > The second run repeats all assertions with no benefit. Drop the > duplicate call.
Guess these two instances would have been introduced just following the adjacent other test cases where one takes true and the other takes false as arguments :) > > Signed-off-by: Hongfu Li <[email protected]> > Reviewed-by: Lorenzo Stoakes (ARM) <[email protected]> > Acked-by: David Hildenbrand (Arm) <[email protected]> Reviewed-by: Anshuman Khandual <[email protected]> > --- > v2: > - update ksft_set_plan(88) to 87 to match the actual number of tests > after removing the duplicate call. > - Add Reviewed-by and Acked-by tags. > --- > tools/testing/selftests/mm/mseal_test.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/mm/mseal_test.c > b/tools/testing/selftests/mm/mseal_test.c > index 93c2e13094d4..1a05e6921fed 100644 > --- a/tools/testing/selftests/mm/mseal_test.c > +++ b/tools/testing/selftests/mm/mseal_test.c > @@ -1876,7 +1876,7 @@ int main(void) > if (!pkey_supported()) > ksft_print_msg("PKEY not supported\n"); > > - ksft_set_plan(88); > + ksft_set_plan(87); > > test_seal_addseal(); > test_seal_unmapped_start(); > @@ -1913,7 +1913,6 @@ int main(void) > test_seal_mprotect_partial_mprotect(false); > test_seal_mprotect_partial_mprotect(true); > > - test_seal_mprotect_two_vma_with_gap(); > test_seal_mprotect_two_vma_with_gap(); > > test_seal_mprotect_merge(false); > -- > 2.54.0 >
