On Sat Jul 4, 2026 at 8:29 AM EDT, Malaya Kumar Rout wrote:
> In msg_alloc_iov(), when calloc() fails for an individual iov_base
> allocation, the error path frees all previously allocated iov_base
> entries but fails to free the iov array itself that was allocated
> with calloc() at the beginning of the function. This results in a
> memory leak of the iov array.
>
> Add free(iov) in the unwind_iov error path to ensure proper cleanup
> of all allocated memory.
>
> Fixes: 753fb2ee0934 ("bpf: sockmap, add msg_peek tests to test_sockmap")
> Signed-off-by: Malaya Kumar Rout <[email protected]>Reviewed-by: Emil Tsalapatis <[email protected]> > --- > tools/testing/selftests/bpf/test_sockmap.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/bpf/test_sockmap.c > b/tools/testing/selftests/bpf/test_sockmap.c > index ac814eb63edb..3e6be455d158 100644 > --- a/tools/testing/selftests/bpf/test_sockmap.c > +++ b/tools/testing/selftests/bpf/test_sockmap.c > @@ -436,6 +436,7 @@ static int msg_alloc_iov(struct msghdr *msg, > unwind_iov: > for (i--; i >= 0 ; i--) > free(msg->msg_iov[i].iov_base); > + free(iov); > return -ENOMEM; > } >
