On Mon, 2026-06-15 at 14:51 -0500, Bill Roberts wrote:
> +     /* test that we can't use unlock to set shadow stack */
> +     if (!ARCH_PRCTL(ARCH_SHSTK_UNLOCK, ARCH_SHSTK_SHSTK)) {
> +             printf("[SKIP]\tCould enable Shadow stack via UNLOCK\n");

Should it be a FAIL? And if this path is taken the test will crash because
shadow stack got accidentally enabled and we can't return from this function. It
can "goto out" and disable shadow stack before returning.

> +             return 1;
> +     }
> +
> +     printf("[OK]\tCouldn't enable Shadow stack via UNLOCK\n");
> +

Reply via email to