On Thu, Mar 26, 2026 at 04:10:42PM -0700, Yosry Ahmed wrote: > On Thu, Mar 26, 2026 at 4:06 PM Andrew Morton <[email protected]> > wrote: > > > > On Thu, 26 Mar 2026 14:29:20 +0800 Li Wang <[email protected]> wrote: > > > > > > Test all passed on: > > > > x86_64(4k), aarch64(4K, 64K), ppc64le(64K). > > > > > > Hi Andrew, All, > > > > > > I see that Sashiko still points out minor issues in this patchset, > > > That seems very tiny in selftest programming. > > > > > > I can correct all that in a new version if you'd like a perfect patchset. > > > > > > Sashiko comments: > > > > > > https://sashiko.dev/#/patchset/20260326032658.96819-1-liwang%40redhat.com > > > > Ah, OK, you already looked. > > > > If you say they're too minor then I'm OK with that. If there are any > > you feel you'd like to address then go for it. That's my opinion, > > others might differ! > > > > I suggest you leave things as-is for a while (a week?), give the memcg > > maintainers time to take a look (please).
Sounds reasonable! > I think some of the comments are worth addressing, especially: +1 > Patch 4: > Using BUF_SIZE in the allocation helpers is wrong, we should use the > actual page size. > > Patch 6: > Zero initialization of zw_allocation. Thanks, and plus: Patch 7: Adjust the code comments. Patch 8: Declear long type for elapsed and count variables > But yeah as Andrew said, it may be worth waiting for memcg maintainers > to take a look before sending a new version. Sure, I will allow a week for others to review it. -- Regards, Li Wang
