mailbox driver can't introduce shutdown callback, as it might endup
closing mbox channels prematurely. By allowing the client driver to
manage the shutdown process, it's ensured that mailbox channels are
closed only when they are no longer needed.

Signed-off-by: Tanmay Shah <[email protected]>
---
 drivers/remoteproc/xlnx_r5_remoteproc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/remoteproc/xlnx_r5_remoteproc.c 
b/drivers/remoteproc/xlnx_r5_remoteproc.c
index 5e92dc51f1c0..50a9974f3202 100644
--- a/drivers/remoteproc/xlnx_r5_remoteproc.c
+++ b/drivers/remoteproc/xlnx_r5_remoteproc.c
@@ -1490,6 +1490,8 @@ static void zynqmp_r5_remoteproc_shutdown(struct 
platform_device *pdev)
                        dev_err(cluster->dev, "failed to %s rproc %d\n",
                                rproc_state_str, rproc->index);
                }
+
+               zynqmp_r5_free_mbox(r5_core->ipi);
        }
 }
 
-- 
2.34.1


Reply via email to