On Fri, Feb 13, 2026 at 12:57:36PM +0200, Leon Romanovsky wrote: > Unify CQ UMEM creation, resize and release in ib_core to avoid the need > for complex driver-side handling. This lets us rely on the internal > reference counters of the relevant ib_XXX objects to manage UMEM > lifetime safely and consistently. > > The resize cleanup made it clear that most drivers never handled this > path correctly, and there's a good chance the functionality was never > actually used. The most common issue was relying on the cq->resize_umem > pointer to detect races with other CQ commands, without clearing it on > errors and while ignoring proper locking for other CQ operations. > > Signed-off-by: Leon Romanovsky <[email protected]> > --- > Leon Romanovsky (50): > RDMA: Move DMA block iterator logic into dedicated files > RDMA/umem: Allow including ib_umem header from any location > RDMA/umem: Remove unnecessary includes and defines from ib_umem header > RDMA/core: Promote UMEM to a core component > RDMA/core: Manage CQ umem in core code > RDMA/efa: Rely on CPU address in create‑QP > RDMA/core: Prepare create CQ path for API unification > RDMA/core: Reject zero CQE count > RDMA/efa: Remove check for zero CQE count > RDMA/mlx5: Save 4 bytes in CQ structure > RDMA/mlx5: Provide a modern CQ creation interface > RDMA/mlx4: Inline mlx4_ib_get_cq_umem into callers > RDMA/mlx4: Introduce a modern CQ creation interface > RDMA/mlx4: Remove unused create_flags field from CQ structure
I took 14 patches above, rest will need to be resubmitted. Thanks > RDMA/bnxt_re: Convert to modern CQ interface > RDMA/cxgb4: Separate kernel and user CQ creation paths > RDMA/mthca: Split user and kernel CQ creation paths > RDMA/erdma: Separate user and kernel CQ creation paths > RDMA/ionic: Split user and kernel CQ creation paths > RDMA/qedr: Convert to modern CQ interface > RDMA/vmw_pvrdma: Provide a modern CQ creation interface > RDMA/ocrdma: Split user and kernel CQ creation paths > RDMA/irdma: Split user and kernel CQ creation paths > RDMA/usnic: Provide a modern CQ creation interface > RDMA/mana: Provide a modern CQ creation interface > RDMA/erdma: Separate user and kernel CQ creation paths > RDMA/rdmavt: Split user and kernel CQ creation paths > RDMA/siw: Split user and kernel CQ creation paths > RDMA/rxe: Split user and kernel CQ creation paths > RDMA/core: Remove legacy CQ creation fallback path > RDMA/core: Remove unused ib_resize_cq() implementation > RDMA: Clarify that CQ resize is a user‑space verb > RDMA/bnxt_re: Drop support for resizing kernel CQs > RDMA/irdma: Remove resize support for kernel CQs > RDMA/mlx4: Remove support for kernel CQ resize > RDMA/mlx5: Remove support for resizing kernel CQs > RDMA/mthca: Remove resize support for kernel CQs > RDMA/rdmavt: Remove resize support for kernel CQs > RDMA/rxe: Remove unused kernel‑side CQ resize support > RDMA: Properly propagate the number of CQEs as unsigned int > RDMA/core: Generalize CQ resize locking > RDMA/bnxt_re: Complete CQ resize in a single step > RDMA/bnxt_re: Rely on common resize‑CQ locking > RDMA/bnxt_re: Reduce CQ memory footprint > RDMA/mlx4: Use generic resize-CQ lock > RDMA/mlx4: Use on‑stack variables instead of storing them in the CQ > object > RDMA/mlx5: Use generic resize-CQ lock > RDMA/mlx5: Select resize‑CQ callback based on device capabilities > RDMA/mlx5: Reduce CQ memory footprint > RDMA/mthca: Use generic resize-CQ lock > > drivers/infiniband/core/Makefile | 6 +- > drivers/infiniband/core/cq.c | 3 + > drivers/infiniband/core/device.c | 4 +- > drivers/infiniband/core/iter.c | 43 +++ > drivers/infiniband/core/umem.c | 2 +- > drivers/infiniband/core/uverbs_cmd.c | 18 +- > drivers/infiniband/core/uverbs_std_types_cq.c | 35 ++- > drivers/infiniband/core/verbs.c | 61 +--- > drivers/infiniband/hw/bnxt_re/ib_verbs.c | 246 ++++++++------- > drivers/infiniband/hw/bnxt_re/ib_verbs.h | 9 +- > drivers/infiniband/hw/bnxt_re/main.c | 3 +- > drivers/infiniband/hw/bnxt_re/qplib_res.c | 2 +- > drivers/infiniband/hw/cxgb4/cq.c | 218 +++++++++---- > drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 2 + > drivers/infiniband/hw/cxgb4/mem.c | 2 +- > drivers/infiniband/hw/cxgb4/provider.c | 1 + > drivers/infiniband/hw/efa/efa.h | 6 +- > drivers/infiniband/hw/efa/efa_main.c | 3 +- > drivers/infiniband/hw/efa/efa_verbs.c | 44 ++- > drivers/infiniband/hw/erdma/erdma_main.c | 1 + > drivers/infiniband/hw/erdma/erdma_verbs.c | 99 ++++-- > drivers/infiniband/hw/erdma/erdma_verbs.h | 2 + > drivers/infiniband/hw/hns/hns_roce_alloc.c | 2 +- > drivers/infiniband/hw/hns/hns_roce_cq.c | 103 ++++-- > drivers/infiniband/hw/hns/hns_roce_debugfs.c | 1 - > drivers/infiniband/hw/hns/hns_roce_device.h | 3 +- > drivers/infiniband/hw/hns/hns_roce_main.c | 1 + > drivers/infiniband/hw/ionic/ionic_controlpath.c | 88 ++++-- > drivers/infiniband/hw/ionic/ionic_ibdev.c | 1 + > drivers/infiniband/hw/ionic/ionic_ibdev.h | 4 +- > drivers/infiniband/hw/irdma/main.h | 2 +- > drivers/infiniband/hw/irdma/verbs.c | 402 > +++++++++++++----------- > drivers/infiniband/hw/mana/cq.c | 128 +++++--- > drivers/infiniband/hw/mana/device.c | 1 + > drivers/infiniband/hw/mana/main.c | 25 +- > drivers/infiniband/hw/mana/mana_ib.h | 6 +- > drivers/infiniband/hw/mana/qp.c | 42 ++- > drivers/infiniband/hw/mana/wq.c | 14 +- > drivers/infiniband/hw/mlx4/cq.c | 401 ++++++++--------------- > drivers/infiniband/hw/mlx4/main.c | 3 +- > drivers/infiniband/hw/mlx4/mlx4_ib.h | 10 +- > drivers/infiniband/hw/mlx4/mr.c | 1 + > drivers/infiniband/hw/mlx5/cq.c | 383 ++++++++-------------- > drivers/infiniband/hw/mlx5/main.c | 9 +- > drivers/infiniband/hw/mlx5/mem.c | 1 + > drivers/infiniband/hw/mlx5/mlx5_ib.h | 12 +- > drivers/infiniband/hw/mlx5/qp.c | 2 +- > drivers/infiniband/hw/mlx5/umr.c | 1 + > drivers/infiniband/hw/mthca/mthca_cq.c | 1 - > drivers/infiniband/hw/mthca/mthca_provider.c | 193 ++++-------- > drivers/infiniband/hw/mthca/mthca_provider.h | 1 - > drivers/infiniband/hw/ocrdma/ocrdma_main.c | 3 +- > drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 70 +++-- > drivers/infiniband/hw/ocrdma/ocrdma_verbs.h | 6 +- > drivers/infiniband/hw/qedr/main.c | 1 + > drivers/infiniband/hw/qedr/verbs.c | 325 +++++++++++-------- > drivers/infiniband/hw/qedr/verbs.h | 2 + > drivers/infiniband/hw/usnic/usnic_ib_main.c | 2 +- > drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 6 +- > drivers/infiniband/hw/usnic/usnic_ib_verbs.h | 4 +- > drivers/infiniband/hw/vmw_pvrdma/pvrdma.h | 2 +- > drivers/infiniband/hw/vmw_pvrdma/pvrdma_cq.c | 171 ++++++---- > drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 1 + > drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.h | 3 + > drivers/infiniband/sw/rdmavt/cq.c | 224 +++++++------ > drivers/infiniband/sw/rdmavt/cq.h | 4 +- > drivers/infiniband/sw/rdmavt/vt.c | 3 +- > drivers/infiniband/sw/rxe/rxe_cq.c | 31 -- > drivers/infiniband/sw/rxe/rxe_loc.h | 3 - > drivers/infiniband/sw/rxe/rxe_verbs.c | 115 +++---- > drivers/infiniband/sw/siw/siw_main.c | 1 + > drivers/infiniband/sw/siw/siw_verbs.c | 111 +++++-- > drivers/infiniband/sw/siw/siw_verbs.h | 2 + > include/rdma/ib_umem.h | 36 +-- > include/rdma/ib_verbs.h | 67 +--- > include/rdma/iter.h | 88 ++++++ > 76 files changed, 2085 insertions(+), 1847 deletions(-) > --- > base-commit: 42e3aac65c1c9eb36cdee0d8312a326196e0822f > change-id: 20260203-refactor-umem-e5b4277e41b4 > > Best regards, > -- > Leon Romanovsky <[email protected]> >
