On 26/02/12 07:44PM, Dmitry Antipov wrote:
> Since '_parse_integer_limit()' (and so 'simple_strtoull()') is now
> capable to handle overflow, adjust 'memparse()' to handle overflow
> (denoted by ULLONG_MAX) returned from 'simple_strtoull()'. Also
> use 'check_shl_overflow()' to catch an overflow possibly caused
> by processing size suffix and denote it with ULLONG_MAX as well.

is returning ULLONG_MAX the proper way to indicate overflow with
simple_strtoull()?

...

>  unsigned long long memparse(const char *ptr, char **retptr)
>  {
>       char *endptr;   /* local pointer to end of parsed string */
> -
>       unsigned long long ret = simple_strtoull(ptr, &endptr, 0);

... or a new wrapper for _parse_integer_limit() is needed?

I am interested on having _parse_integer_limit() overflow check
exposed to kernel modules.
...

-- 
Kind regards,

Rodrigo Alencar

Reply via email to