On 2/23/26 5:08 AM, Erni Sri Satya Vennela wrote:
> @@ -861,8 +862,8 @@ int mana_hwc_send_request(struct hw_channel_context *hwc,
> u32 req_len,
> tx_wr = &txq->msg_buf->reqs[msg_id];
>
> if (req_len > tx_wr->buf_len) {
> - dev_err(hwc->dev, "HWC: req msg size: %d > %d\n", req_len,
> - tx_wr->buf_len);
> + dev_err(hwc->dev, "%s:%d: req msg size: %d > %d\n",
> + __func__, __LINE__, req_len, tx_wr->buf_len);
I fail to see any relevant information added here ...
> err = -EINVAL;
> goto out;
> }
> @@ -878,6 +879,7 @@ int mana_hwc_send_request(struct hw_channel_context *hwc,
> u32 req_len,
> req_msg->req.hwc_msg_id = msg_id;
>
> tx_wr->msg_size = req_len;
> + command = req_msg->req.msg_type;
>
> if (gc->is_pf) {
> dest_vrq = hwc->pf_dest_vrq_id;
> @@ -886,15 +888,16 @@ int mana_hwc_send_request(struct hw_channel_context
> *hwc, u32 req_len,
>
> err = mana_hwc_post_tx_wqe(txq, tx_wr, dest_vrq, dest_vrcq, false);
> if (err) {
> - dev_err(hwc->dev, "HWC: Failed to post send WQE: %d\n", err);
> + dev_err(hwc->dev, "%s:%d: Failed to post send WQE: %d\n",
> + __func__, __LINE__, err);
... and here. The string message should be (and apparently is) enough to
locate the relevant code inside the tree. Please don't included
unneeded/irrelevant changes.
Thanks,
Paolo
