On Thu, Jan 29, 2026 at 06:43:18PM -0800, Jakub Kicinski via Devel wrote:
> On Wed, 28 Jan 2026 11:20:45 +0100 Antony Antony wrote:
> > Test that ICMP error messages generated by an IPsec gateway use
> > the correct source address (the gateway's address, not the
> > unreachable destination).
>
> could you check / fix shellcheck warnings?
lots of warnings. It looks like x-mas lights are still on:)
>
> +In xfrm_state.sh line 115:
> + $ksft_skip)
> + ^--------^ SC2254 (warning): Quote expansions in case patterns to
> match literally rather than as a glob.
I will add quotes to. Thare 30-40 of those!
>
> +In xfrm_state.sh line 157:
> + [ -n "${NS_R1}" ] && ns_r1="ip netns exec ${NS_R1}" &&
> ns_active="${ns_active} $NS_R1"
> + ^---^ SC2034 (warning): ns_r1 appears unused.
> Verify use (or export if used externally).
> +
> +
> +In xfrm_state.sh line 162:
> + [ -n "${NS_B}" ] && ns_b="ip netns exec ${NS_B}" &&
> ns_active="${ns_active} $NS_B"
> + ^--^ SC2034 (warning): ns_b appears unused.
> Verify use (or export if used externally).
>
> +In xfrm_state.sh line 166:
> + local ns_cmd=$(nscmd $1)
> + ^----^ SC2155 (warning): Declare and assign separately to
> avoid masking return values.
other shell checks are harder to fix.
+In xfrm_state.sh line 417:
test_unreachable_ipv6() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored
if invoked indirectly).
those are invoked indirectly. eval code I would like to keep. Would that
work for you? are you aiming fori strictly zero warnings?
regards,
-antony
