On 12/01/2026 10:03, Kevin Brodsky wrote: > On 12/01/2026 10:34, Ryan Roberts wrote: >>> - if (!check_vmflag_pfnmap(self->addr1)) >>> - SKIP(return, "Invalid file: '%s'. Not pfnmap'ed\n", file); >> I wonder if we still want this check per-fd, but upgraded to a fail? > > It seems very unlikely to fail though, I can only think of the > underlying file having changed in between but I really wouldn't expect > that for such special files. I was trying not to duplicate the checks > too much.
Fair enough. No strong opinion from me. I just thought that given this is a test that claims to be checking the behaviour of pfnmaps, then we ought to be pretty sure we have a pfnmap. > > - Kevin
