On Mon, Dec 15, 2025 at 10:35:09AM +0400, George Moussalem via B4 Relay wrote:
> From: George Moussalem <[email protected]>
> 
> The IPC register in IPQ5424 is at offset 0xc instead of 0x8 as defined
> in driver data for msm8994. As such, switch to the existing
> apps_shared_apcs_data driver data which has offset set to 0xc.
> 

This doesn't have any compile time dependencies to the rest of the
series, so it would be better to send separately to make this clear.

Further, there should be a Fixes: tag here, and if there are any users a
Cc: stable@....

Regards,
Bjorn

> Signed-off-by: George Moussalem <[email protected]>
> ---
>  drivers/mailbox/qcom-apcs-ipc-mailbox.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c 
> b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> index 
> d3a8f6b4a03b368821ef9a5b24fee78037104610..258b03307869b244e053e7a355531268114906df
>  100644
> --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> @@ -164,7 +164,7 @@ static const struct of_device_id qcom_apcs_ipc_of_match[] 
> = {
>       { .compatible = "qcom,sm6125-apcs-hmss-global", .data = 
> &msm8994_apcs_data },
>       { .compatible = "qcom,sm6115-apcs-hmss-global", .data = 
> &msm8994_apcs_data },
>       { .compatible = "qcom,ipq5332-apcs-apps-global", .data = 
> &ipq6018_apcs_data },
> -     { .compatible = "qcom,ipq5424-apcs-apps-global", .data = 
> &msm8994_apcs_data },
> +     { .compatible = "qcom,ipq5424-apcs-apps-global", .data = 
> &apps_shared_apcs_data },
>       { .compatible = "qcom,ipq8074-apcs-apps-global", .data = 
> &ipq6018_apcs_data },
>       { .compatible = "qcom,sc7180-apss-shared", .data = 
> &apps_shared_apcs_data },
>       { .compatible = "qcom,sc8180x-apss-shared", .data = 
> &apps_shared_apcs_data },
> 
> -- 
> 2.52.0
> 
> 

Reply via email to