On 12/13/25 14:00, David Heidelberg via B4 Relay wrote:
From: David Heidelberg <[email protected]>

There are shared for the whole architecture, so let's define these in
proper place.

Signed-off-by: David Heidelberg <[email protected]>
---
  arch/arm64/boot/dts/qcom/sdm845.dtsi | 43 ++++++++++++++++++++++++++++++++++++
  1 file changed, 43 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi 
b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index bf2f9c04adba7..97bd9513b011b 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -2805,6 +2805,49 @@ tlmm: pinctrl@3400000 {
                        gpio-ranges = <&tlmm 0 0 151>;
                        wakeup-parent = <&pdc_intc>;
+ cam_mclk0_default: cam-mclk0-default-state {
+                               pins = "gpio13";
+                               function = "cam_mclk";
+                               drive-strength = <2>;
+                               bias-disable;
+                       };
+
+                       cam_mclk0_sleep: cam-mclk0-sleep-state {
+                               pins = "gpio13";
+                               function = "cam_mclk";
+                               drive-strength = <2>;
+                               bias-pull-down;
+                       };
+
+                       cam_mclk1_default: cam-mclk1-default-state {
+                               pins = "gpio14";
+                               function = "cam_mclk";
+                               drive-strength = <2>;
+                               bias-disable;
+                       };
+
+                       cam_mclk1_sleep: cam-mclk1-sleep-state {
+                               pins = "gpio14";
+                               function = "cam_mclk";
+                               drive-strength = <2>;
+                               bias-pull-down;
+                       };
+
+                       cam_mclk2_default: cam-mclk2-default-state {
+                               pins = "gpio15";
+                               function = "cam_mclk";
+                               drive-strength = <2>;
+                               bias-disable;
+                       };
+
+                       cam_mclk2_sleep: cam-mclk2-sleep-state {
+                               pins = "gpio15";
+                               function = "cam_mclk";
+                               drive-strength = <2>;
+                               bias-pull-down;
+                       };
+
+

Please remove an excessive blank line.

                        cci0_default: cci0-default-state {
                                /* SDA, SCL */
                                pins = "gpio17", "gpio18";


Please add mclk3 to the list, it's one of the gpio16 pad functions.

After adding that

Reviewed-by: Vladimir Zapolskiy <[email protected]>

--
Best wishes,
Vladimir

Reply via email to