On Tue, Sep 16, 2025 at 06:09:47PM -0700, Paul Sajna wrote: > in accordance with: > https://docs.kernel.org/devicetree/bindings/dts-coding-style.html
Please don't continue commit subject into commit message. It should be a separate complete text. > > Signed-off-by: Paul Sajna <sajatt...@postmarketos.org> > --- > arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 124 > ++++++++++++------------- > 1 file changed, 62 insertions(+), 62 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi > b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi > index > 99dafc6716e76e25aad0755e6004dc952779689f..82d6543835324ed92300c4ed24c51f4b79321f99 > 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi > @@ -38,11 +38,6 @@ reserved-memory { > #size-cells = <2>; > ranges; > > - qseecom_mem: memory@b2000000 { > - reg = <0 0xb2000000 0 0x1800000>; > - no-map; > - }; > - > gpu_mem: memory@8c415000 { > reg = <0 0x8c415000 0 0x2000>; > no-map; > @@ -99,6 +94,11 @@ memory@9d400000 { > no-map; > }; > > + qseecom_mem: memory@b2000000 { > + reg = <0 0xb2000000 0 0x1800000>; > + no-map; > + }; > + > /* rmtfs lower guard */ > memory@f0800000 { > reg = <0 0xf0800000 0 0x1000>; > @@ -482,14 +482,22 @@ &mss_pil { > status = "okay"; > }; > > +&pm8998_gpios { > + vol_up_pin_a: vol-up-active-state { > + pins = "gpio6"; > + function = "normal"; > + input-enable; > + bias-pull-up; > + qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>; > + }; > +}; > + > &pm8998_resin { > linux,code = <KEY_VOLUMEDOWN>; > status = "okay"; > }; > > &sdhc_2 { > - status = "okay"; > - > cd-gpios = <&tlmm 126 GPIO_ACTIVE_LOW>; > > pinctrl-names = "default"; > @@ -497,55 +505,8 @@ &sdhc_2 { > > vmmc-supply = <&vreg_l21a_2p95>; > vqmmc-supply = <&vddpx_2>; > -}; > - > -/* > - * UFS works partially and only with clk_ignore_unused. > - * Sometimes it crashes with I/O errors. > - */ > -&ufs_mem_hc { > - status = "okay"; > - > - reset-gpios = <&tlmm 150 GPIO_ACTIVE_LOW>; > - > - vcc-supply = <&vreg_l20a_2p95>; > - vcc-max-microamp = <600000>; > -}; > - > -&ufs_mem_phy { > - status = "okay"; > - > - vdda-phy-supply = <&vdda_ufs1_core>; > - vdda-pll-supply = <&vdda_ufs1_1p2>; > -}; > - > -&usb_1 { > - status = "okay"; > -}; > - > -&usb_1_dwc3 { > - /* TODO: these devices have usb id pin */ > - dr_mode = "peripheral"; > -}; > - > -&usb_1_hsphy { > - status = "okay"; > - > - vdd-supply = <&vdda_usb1_ss_core>; > - vdda-pll-supply = <&vdda_qusb_hs0_1p8>; > - vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>; > - > - qcom,imp-res-offset-value = <8>; > - qcom,hstx-trim-value = <QUSB2_V2_HSTX_TRIM_21_6_MA>; > - qcom,preemphasis-level = <QUSB2_V2_PREEMPHASIS_5_PERCENT>; > - qcom,preemphasis-width = <QUSB2_V2_PREEMPHASIS_WIDTH_HALF_BIT>; > -}; > > -&usb_1_qmpphy { > status = "okay"; > - > - vdda-phy-supply = <&vdda_usb1_ss_1p2>; > - vdda-pll-supply = <&vdda_usb1_ss_core>; > }; > > /* PINCTRL - additions to nodes defined in sdm845.dtsi */ > @@ -586,12 +547,51 @@ sd_card_det_n: sd-card-det-n-state { > }; > }; > > -&pm8998_gpios { > - vol_up_pin_a: vol-up-active-state { > - pins = "gpio6"; > - function = "normal"; > - input-enable; > - bias-pull-up; > - qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>; > - }; > +/* > + * UFS works partially and only with clk_ignore_unused. > + * Sometimes it crashes with I/O errors. > + */ > +&ufs_mem_hc { > + reset-gpios = <&tlmm 150 GPIO_ACTIVE_LOW>; > + > + vcc-supply = <&vreg_l20a_2p95>; > + vcc-max-microamp = <600000>; > + > + status = "okay"; > +}; > + > +&ufs_mem_phy { > + vdda-phy-supply = <&vdda_ufs1_core>; > + vdda-pll-supply = <&vdda_ufs1_1p2>; > + > + status = "okay"; > +}; > + > +&usb_1 { > + status = "okay"; > +}; > + > +&usb_1_dwc3 { > + /* TODO: these devices have usb id pin */ > + dr_mode = "peripheral"; > +}; > + > +&usb_1_hsphy { > + vdd-supply = <&vdda_usb1_ss_core>; > + vdda-pll-supply = <&vdda_qusb_hs0_1p8>; > + vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>; > + > + qcom,imp-res-offset-value = <8>; > + qcom,hstx-trim-value = <QUSB2_V2_HSTX_TRIM_21_6_MA>; > + qcom,preemphasis-level = <QUSB2_V2_PREEMPHASIS_5_PERCENT>; > + qcom,preemphasis-width = <QUSB2_V2_PREEMPHASIS_WIDTH_HALF_BIT>; > + > + status = "okay"; > +}; > + > +&usb_1_qmpphy { > + vdda-phy-supply = <&vdda_usb1_ss_1p2>; > + vdda-pll-supply = <&vdda_usb1_ss_core>; > + > + status = "okay"; > }; > > -- > 2.51.0 > -- With best wishes Dmitry